Skip to content

Added option to specify initial number of lines in pyodide fence editors#90

Merged
pawamoy merged 3 commits intopawamoy:mainfrom
jayantpranjal0:configure_lines
Jun 28, 2025
Merged

Added option to specify initial number of lines in pyodide fence editors#90
pawamoy merged 3 commits intopawamoy:mainfrom
jayantpranjal0:configure_lines

Conversation

@jayantpranjal0
Copy link
Copy Markdown
Contributor

@jayantpranjal0 jayantpranjal0 commented Jun 26, 2025 •
edited
Loading

Closes #41

@jayantpranjal0 jayantpranjal0 marked this pull request as draft June 26, 2025 23:17
@jayantpranjal0 jayantpranjal0 marked this pull request as ready for review June 26, 2025 23:29
@jayantpranjal0
Copy link
Copy Markdown
Contributor Author

jayantpranjal0 commented Jun 26, 2025

@pawamoy can you check out the PR and why the test is failing?

pawamoy
pawamoy reviewed Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks!

I realized that height and resize were mutually exclusive with min_height and max_height, so I figured we could fit everything into a single option called height. This allowed to simplify the code, too (I've pushed my changes). Let me know what you think. You'll still get the bounty 😉

@jayantpranjal0
Copy link
Copy Markdown
Contributor Author

jayantpranjal0 commented Jun 27, 2025

Yeah, that would be more concise. And thanks for letting me keep the bounty.
Also, I went through your page and found the concept of sponsorware interesting. Please, let me know, if u have any opportunities or any leads for open source work for bounties or some other way of getting paid for open source work.

@pawamoy
Copy link
Copy Markdown
Owner

pawamoy commented Jun 27, 2025

Well if you have one or more somewhat popular projects, you could try to follow the sponsorware approach too 🙂

@jayantpranjal0
Copy link
Copy Markdown
Contributor Author

jayantpranjal0 commented Jun 27, 2025

Right now I don't have any good enough projects to be sponsored, but will get on the path for sure.
Thanks btw.
Please let me know if you need anything else to get the PR merged?

pawamoy
pawamoy approved these changes Jun 28, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again @jayantpranjal0! I believe you don't need anything from me to get the bounty on the related platform once your PR is merged?

@pawamoy pawamoy merged commit c64a2ef into pawamoy:main Jun 28, 2025
2 of 26 checks passed
@jayantpranjal0 jayantpranjal0 deleted the configure_lines branch June 29, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: Add option to specify initial number of lines in pyodide fence editors

2 participants

@jayantpranjal0 @pawamoy