Skip to content

Commit d80d54d

Browse files
committed
typechecking: add pyright: ignores for pyrights pyarrow warnings.
Signed-off-by: Paul Timmins <[email protected]>
1 parent d53be9c commit d80d54d

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

‎vortex-python/python/vortex/arrow/expression.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ def _schema_for_substrait(schema: pa.Schema) -> pa.Schema:
3434
# If/When PyArrow to_substrait supports view types, revert.
3535
# Workaround for: https://github.com/vortex-data/vortex/issues/5759
3636
fields = []
37-
for field in schema:
38-
if field.type == pa.string_view():
39-
fields.append(field.with_type(pa.string()))
40-
elif field.type == pa.binary_view():
41-
fields.append(field.with_type(pa.binary()))
37+
for field in schema: # pyright: ignore[reportUnknownVariableType]
38+
if field.type == pa.string_view(): # pyright: ignore[reportUnknownMemberType]
39+
fields.append(field.with_type(pa.string())) # pyright: ignore[reportUnknownMemberType]
40+
elif field.type == pa.binary_view(): # pyright: ignore[reportUnknownMemberType]
41+
fields.append(field.with_type(pa.binary())) # pyright: ignore[reportUnknownMemberType]
4242
else:
43-
fields.append(field)
44-
return pa.schema(fields)
43+
fields.append(field) # pyright: ignore[reportUnknownMemberType]
44+
return pa.schema(fields) # pyright: ignore[reportUnknownArgumentType]
4545

4646

4747
def arrow_to_vortex(arrow_expression: pc.Expression, schema: pa.Schema) -> Expr:

‎vortex-python/test/test_expression.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import pyarrow as pa
77
import pyarrow.compute as pc
88
import pytest
9-
from vortex.arrow.expression import _schema_for_substrait, arrow_to_vortex
9+
from vortex.arrow.expression import _schema_for_substrait, arrow_to_vortex # pyright: ignore[reportPrivateUsage]
1010

1111

1212
class TestSchemaForSubstrait:
@@ -15,12 +15,12 @@ class TestSchemaForSubstrait:
1515
def test_string_view_mapped_to_string(self):
1616
schema = pa.schema([("col", pa.string_view())])
1717
result = _schema_for_substrait(schema)
18-
assert result.field("col").type == pa.string()
18+
assert result.field("col").type == pa.string() # pyright: ignore[reportUnknownMemberType]
1919

2020
def test_binary_view_mapped_to_binary(self):
2121
schema = pa.schema([("col", pa.binary_view())])
2222
result = _schema_for_substrait(schema)
23-
assert result.field("col").type == pa.binary()
23+
assert result.field("col").type == pa.binary() # pyright: ignore[reportUnknownMemberType]
2424

2525
def test_other_types_unchanged(self):
2626
schema = pa.schema(
@@ -95,8 +95,8 @@ def test_mixed_view_and_regular_types(self):
9595
(pa.binary_view(), b"test"),
9696
],
9797
)
98-
def test_view_types_parametrized(self, view_type, value):
99-
schema = pa.schema([("col", view_type)])
100-
expr = pc.field("col") == value
101-
vortex_expr = arrow_to_vortex(expr, schema)
98+
def test_view_types_parametrized(self, view_type, value): # pyright: ignore[reportMissingParameterType, reportUnknownParameterType]
99+
schema = pa.schema([("col", view_type)]) # pyright: ignore[reportUnknownArgumentType]
100+
expr = pc.field("col") == value # pyright: ignore[reportUnknownVariableType]
101+
vortex_expr = arrow_to_vortex(expr, schema) # pyright: ignore[reportUnknownArgumentType]
102102
assert vortex_expr is not None

0 commit comments

Comments
 (0)