Add ChildrenInZoomRange method#133
Merged
paulmach merged 2 commits intopaulmach:masterfrom Jul 16, 2023
Merged
Conversation
Author
|
@paulmach would you please take a look? |
paulmach
reviewed
Jul 14, 2023
maptile/tile.go
Outdated
|
|
||
| // ChildrenInZoomRange returns all the children tiles of tile from ranges [zoomStart, zoomEnd], both ends inclusive. | ||
| func ChildrenInZoomRange(tile Tile, zoomStart, zoomEnd Zoom) Tiles { | ||
| if zoomStart < tile.Z || zoomEnd < tile.Z { |
Owner
There was a problem hiding this comment.
I think this should be two checks
if !(zoomStart <= zoomEnd) {
panic("zoomStart must be <= zoomEnd")
}
Then
if !(tile.Z <= zoomStart) {
panic("tile.Z must be <= zoomStart")
}
maptile/tile.go
Outdated
| for d := zDeltaStart; d <= zDeltaEnd; d++ { | ||
| xTopLeft := tile.X << d | ||
| yTopLeft := tile.Y << d | ||
| dim := uint32(math.Pow(2, float64(d))) |
Author
There was a problem hiding this comment.
Good point, fixed in next commit.
maptile/tile.go
Outdated
| res := make([]Tile, 0) | ||
|
|
||
| for d := zDeltaStart; d <= zDeltaEnd; d++ { | ||
| xTopLeft := tile.X << d |
Owner
There was a problem hiding this comment.
this variable seems more like left or xStart
Then the next one is more like top or yStart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a utility method to generate all children tiles of a tile.