Set minimum points for a VisvalingamThreshold simplification#124
Closed
albertyw wants to merge 2 commits intopaulmach:masterfrom
Closed
Set minimum points for a VisvalingamThreshold simplification#124albertyw wants to merge 2 commits intopaulmach:masterfrom
albertyw wants to merge 2 commits intopaulmach:masterfrom
Conversation
Author
|
Considering this more, I see that Visvalingam may be applied to LineStrings and other types which may have no expectation of a non-zero area or more than 2 unique points. Similar to the discussion in #45, perhaps that indicates there should be no minimum number of points (other than the minimum of 2 points being the organic result of applying the algorithm) and users may need to instead specify number of points explicitly. I'm no expert in geojson so I'd be happy to discuss approaches. |
Owner
|
this pr #140 updated "zero min points" to mean
I think that was the intention by this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
VisvalingamThresholdsimplification allows polygons to be simplified to 2 points which, at 0 area, is likely not the intention of the user nor does it produce a polygon that follows the geojson standard (#45). This changes the default to 3 points minimum.VisvalingamandVisvalingamKeepwill still allow users to explicitly specify 0, 1, or 2 points minimum if actually desired.