Make confirmation bottom sheets working when animations are disabled#938
Merged
patzly merged 1 commit intopatzly:masterfrom Aug 24, 2025
Merged
Make confirmation bottom sheets working when animations are disabled#938patzly merged 1 commit intopatzly:masterfrom
patzly merged 1 commit intopatzly:masterfrom
Conversation
Owner
|
Your pull request seems fine, thank you for your contribution! I will publish an app update in a few weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When animations are disabled system-wide (or disabled automatically when battery is low on Samsung devices), bottom sheets with 3-second timeout are skipped and their action is done immediately.
This is especially problematic in Purchase flow when one needs to update the number of items purchased.
This PR fixes it by introducing a ValueAnimatorUtil - a class implementing a subset of ValueAnimator functionality. The implementation is not affected by system-wide animation scaling, therefore confirmation bottom sheets will be shown in such cases too, with their progress bars animating.