Fixes for feature/client certificates#892
Merged
patzly merged 3 commits intopatzly:feature/client_certificatesfrom Dec 25, 2024
Merged
Fixes for feature/client certificates#892patzly merged 3 commits intopatzly:feature/client_certificatesfrom
patzly merged 3 commits intopatzly:feature/client_certificatesfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see my suggestions to fix client_certificate support.
It works for me, at least, no crashes and no misleading toasts.