Repository navigation
fix(queue): hold queued messages while editing - #533
Merged
Merged
Conversation
Import pingdotgg#15612 and retain the editing indicator in the fork surface contract. Co-authored-by: Andrew Forster <[email protected]>
patroza
marked this pull request as ready for review
October 12, 2026 07:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the active turn finishes while a queued message is being edited, the original text can start before Save. Import upstream #15612 to acquire a server edit hold before opening the editor, keeping queue order until Save or Cancel.
Web, desktop, and mobile share the hold commands. Stale editors cannot overwrite a newer edit, and existing Stop/restart pauses remain held. Includes upstream regression tests and a fork surface assertion for the Editing indicator.
Validation: draft push gate passed changed-file checks and workspace typecheck. Integrated browser verification passed edit hold acquisition, ending the active preparing run while editing (original stayed queued), Save dispatching revised text, Cancel keeping original text, reopening the editor, and Save/Cancel preserving a paused queue. Provider execution was unavailable in the isolated environment; orchestration regression tests cover provider turn completion. The full publish gate passed workspace lint/format, typecheck, and tests, including 6,330 server tests. Published through
pnpm pr:ready; required GitHub checks are pending. Native mobile verification is unavailable because Device support is off; desktop uses the verified web flow without shell changes.Imported from Andrew Forster’s upstream PR, adapted with Codex (gpt-6.1-sol).