Skip to content

Commit bb01fe8

Browse files
fix(mobile): keep conversation feed visible (#232)
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
1 parent a8e4e69 commit bb01fe8

2 files changed

Lines changed: 31 additions & 2 deletions

File tree

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -764,12 +764,12 @@ function ThreadRouteContent(
764764
const renderThreadRouteBody = (showActionControls: boolean) => (
765765
// A real flex host (not a fragment) keeps the thread body filling the
766766
// screen so the absolute composer overlay anchors to the true bottom.
767-
<View className="flex-1 bg-screen">
767+
<View testID="thread-conversation-surface" className="flex-1 bg-screen" style={{ flex: 1 }}>
768768
<ThreadGitControls {...threadGitControlProps} showActionControls={showActionControls} />
769769

770770
<GitActionProgressOverlay progress={gitActionProgress} onDismiss={dismissGitActionResult} />
771771

772-
<View className="flex-1">
772+
<View className="flex-1" style={{ flex: 1 }}>
773773
<ThreadDetailScreen
774774
selectedThread={selectedThreadWithDraftSettings ?? selectedThread}
775775
contentPresentation={contentPresentation}
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
/**
2+
* Existence contracts for mobile product surfaces that stack conflict
3+
* resolution can accidentally leave structurally present but unrenderable.
4+
*/
5+
// @effect-diagnostics nodeBuiltinImport:off - existence contract reads source text on disk.
6+
import * as NodeFS from "node:fs";
7+
import * as NodePath from "node:path";
8+
import * as NodeURL from "node:url";
9+
import { describe, expect, it } from "vite-plus/test";
10+
11+
const root = NodePath.dirname(NodeURL.fileURLToPath(import.meta.url));
12+
13+
function readSrc(relativePath: string): string {
14+
return NodeFS.readFileSync(NodePath.join(root, relativePath), "utf8");
15+
}
16+
17+
describe("mobile surface existence (anti stack-drop)", () => {
18+
it("keeps the conversation feed inside an explicit flex host", () => {
19+
const threadRoute = readSrc("features/threads/ThreadRouteScreen.tsx");
20+
21+
expect(threadRoute).toContain('testID="thread-conversation-surface"');
22+
expect(threadRoute).toMatch(
23+
/testID="thread-conversation-surface"[\s\S]*?style=\{\{ flex: 1 \}\}/,
24+
);
25+
expect(threadRoute).toMatch(
26+
/<View className="flex-1" style=\{\{ flex: 1 \}\}>[\s\S]*?<ThreadDetailScreen/,
27+
);
28+
});
29+
});

0 commit comments

Comments
 (0)