Merged
Conversation
patrickfav
changed the title
Owner
Author
|
@davidmigloz If you have time, please take a look at this PR |
Contributor
|
I'll try to find some time tomorrow to review it. Thanks for the work! |
Closed
Owner
Author
|
Hey @davidmigloz I will release 0.6.0 this week; just want to check if you will get a chance to look at the PR :) |
Contributor
|
Hi @patrickfav! Sorry for the delay, I started reviewing it last week but I run out of time. I'll try to review it between tonight and tomorrow. |
Contributor
|
I've finished the review, it looks awesome. I really like the way you've implemented the multi-protocol decryption support. I haven't found anything and you've written quite a lot of tests. So I guess it's good to go! 😄 |
Owner
Author
|
Great to hear. I had some offline reviews, so some of the issues maybe already fixed before you reviewed them :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements AES/CBC + HMAC (Encrypt-then-MAC) encryption for Kitkat devices which do not support AES/GCM (see #6). It also adds migration support if the device gets updated to a newer version.
Intentionally the user must enable kitkat support manually.