fix miscellaneous issues which could cause unexpected behavior/errors#86
Merged
patrickdemers6 merged 1 commit intomainfrom Sep 10, 2023
Merged
fix miscellaneous issues which could cause unexpected behavior/errors#86patrickdemers6 merged 1 commit intomainfrom
patrickdemers6 merged 1 commit intomainfrom
Conversation
Owner
patrickdemers6
commented
Sep 6, 2023
patrickdemers6
commented
- Default backend host environment variable for expo builds
- Only add eventListener for dimensions on initial render, not every rerender.
- Do not try reconnecting to websocket if websocket doesn't exist
- Retry grabbing data on unexpected status code.
Nick-Vazquez
reviewed
Sep 9, 2023
| return dataResponse.json(); | ||
| } | ||
|
|
||
| throw new Error('something went wrong'); |
There was a problem hiding this comment.
To double check, looks like retrying was already implemented beforehand, just errors wouldn't be caught if the request fell through the conditionals?
Owner
Author
There was a problem hiding this comment.
Yep if there was success status code but something unexpected, it is possible the app would stay loading forever. No reason to think this is happening, but came across and figured that isn't how we would want it to behave.
Nick-Vazquez
approved these changes
Sep 9, 2023
Nick-Vazquez
left a comment
Nick-Vazquez
left a comment
There was a problem hiding this comment.
Looks good, just had the single question about the catch statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.