Repository navigation
Commit 2541e50
authored
[a11y] Fixes SnackBar showing more Voice Control labels than expected (flutter#194614)
Fixes flutter#157630
SnackBar incorrectly had an VoiceControl label attributed to it, because
SnackBar technically has 3 actions attributed to it - kDismiss,
kScrollUp, and kScrollDown.
In this PR I exclude kDismiss and kScrollUp/Down/Left/Right from ever
receiving VoiceOver labels.
- kDismiss: only maps to Escape, not Tap. It's only used in
`accessibilityPerformEscape`, which is the VoiceOver 2 finger Z-scrub or
verbal "Go back" command.
- kScrollUp/Down/Left/Right: Scrollables are rendered as a native
UIScrollView, not as an SemanticsObject, so shouldn't receive a
VoiceControl label.
<img width="814" height="1770" alt="image"
src="https://github.com/user-attachments/assets/cdf02512-d947-4473-9549-a280151f25bc"
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.1 parent 56aa96c commit 2541e50
2 files changed
Lines changed: 22 additions & 2 deletions
File tree
- engine/src/flutter/shell/platform/darwin/ios/framework/Source
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
861 | 861 | | |
862 | 862 | | |
863 | 863 | | |
864 | | - | |
865 | | - | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
866 | 868 | | |
867 | 869 | | |
868 | 870 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1572 | 1572 | | |
1573 | 1573 | | |
1574 | 1574 | | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
1575 | 1593 | | |
0 commit comments