Skip to content

Comments

build/pkgs/fplll: Update to 5.5.0; fpylll: Update to 0.6.2#444

Merged
mkoeppe merged 3 commits intomainfrom
fplll-5.5.0
Dec 9, 2024
Merged

build/pkgs/fplll: Update to 5.5.0; fpylll: Update to 0.6.2#444
mkoeppe merged 3 commits intomainfrom
fplll-5.5.0

Conversation

@mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Nov 22, 2024 •
edited
Loading

@mkoeppe mkoeppe force-pushed the fplll-5.5.0 branch 2 times, most recently from 00c83e1 to e80dd57 Compare November 23, 2024 00:55
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 23, 2024 •
edited
Loading

https://github.com/passagemath/passagemath/actions/runs/11982538387/job/33410816375?pr=444#step:11:3315

  [fpylll-0.6.1]   [spkg-install] build/src/fpylll/fplll/integer_matrix.cpp:14142:34: error: 'class fplll::ZZ_mat<__mpz_struct [1]>' has no member named 'gen_ntrulike_withq'; did you mean 'gen_ntrulike_bits'?
  [fpylll-0.6.1]   [spkg-install] 14142 |         __pyx_v_self->_core.mpz->gen_ntrulike_withq(__pyx_t_4);
  [fpylll-0.6.1]   [spkg-install]       |                                  ^~~~~~~~~~~~~~~~~~
  [fpylll-0.6.1]   [spkg-install]       |                                  gen_ntrulike_bits
  [fpylll-0.6.1]   [spkg-install] build/src/fpylll/fplll/integer_matrix.cpp:14162:41: error: 'class fplll::ZZ_mat<long int>' has no member named 'gen_ntrulike_withq'; did you mean 'gen_ntrulike_bits'?
  [fpylll-0.6.1]   [spkg-install] 14162 |         __pyx_v_self->_core.__pyx_long->gen_ntrulike_withq(__pyx_t_4);
  [fpylll-0.6.1]   [spkg-install]       |                                         ^~~~~~~~~~~~~~~~~~
  [fpylll-0.6.1]   [spkg-install]       |                                         gen_ntrulike_bits
  [fpylll-0.6.1]   [spkg-install] build/src/fpylll/fplll/integer_matrix.cpp:14266:47: error: cannot convert 'int' to 'const fplll::Z_NR<__mpz_struct [1]>&'
  [fpylll-0.6.1]   [spkg-install] 14266 |         __pyx_v_self->_core.mpz->gen_ntrulike(__pyx_t_4);

Looks like an update of fpylll may be be needed? @malb

@mkoeppe mkoeppe marked this pull request as draft November 23, 2024 01:23
@mkoeppe mkoeppe added the dependencies Pull requests that update a dependency file label Nov 23, 2024
mkoeppe added a commit to passagemath/upstream-fpylll that referenced this pull request Dec 6, 2024
@mkoeppe
.github/workflows/release.yml: Use passagemath/passagemath#444
eb1259a
mkoeppe added a commit to passagemath/upstream-fpylll that referenced this pull request Dec 6, 2024
@mkoeppe
.github/workflows/release.yml: Use passagemath/passagemath#444
739a352
@mkoeppe mkoeppe mentioned this pull request Dec 6, 2024
Merged
@mkoeppe mkoeppe changed the title build/pkgs/fplll: Update to 5.5.0 build/pkgs/fplll: Update to 5.5.0; fpylll: Update to 0.6.2 Dec 7, 2024
@mkoeppe mkoeppe marked this pull request as ready for review December 9, 2024 23:56
@mkoeppe mkoeppe merged commit 14f2e49 into main Dec 9, 2024
@mkoeppe mkoeppe deleted the fplll-5.5.0 branch December 9, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file Upstream candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mkoeppe