Skip to content

fix(server): Antigravity Auto asks instead of approving every request - #3

Open
parmartejass wants to merge 1667 commits into
mainfrom
fix/antigravity-auto-asks
Open

parmartejass wants to merge 1667 commits into
mainfrom
fix/antigravity-auto-asks

Conversation

@parmartejass

Copy link
Copy Markdown
Owner

Before: in Auto, Antigravity commands and edits ran unasked.
After: in Auto, Antigravity asks first (Supervised).

Problem

docs/user/permission-modes.md says Antigravity has no automatic review and that Auto "falls back to asking". It didn't. Antigravity declared no supportedRuntimeModes, so Auto reached the shared ACP policy. There, Auto with no sandbox returns allow for every permission request and client terminal. Example: an edit to /etc/passwd was approved silently.

Grok and OpenCode each handle this themselves. Muse and Pi use the central fallback in RuntimePolicy.providerRuntimeMode. Antigravity did neither.

Change

  • Declare Antigravity's supported modes without auto.
  • The existing central fallback then runs Auto threads as Supervised. This covers prompts, client terminals, and the picker, with no Antigravity-specific policy code.

Scope and approval

Small, focused security fix. It restores documented behavior.

Verification

  • New test in AntigravityProvider.test.ts. Fails on main (supportedRuntimeModes is undefined); passes now.
  • AntigravityProvider, RuntimePolicy, and AntigravityAdapterV2 tests: 26/26 pass.
  • vp run check:changed: all checks pass.
  • Not checked: a live Antigravity session.

Generated by Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T15:26:05.588552Z f03620c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Oct 26, 2026
voida6 and others added 26 commits November 1, 2026 02:30
…ge instead of failing every time (pingdotgg#26651)

Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: maria-rcks <[email protected]>
…27249)

Co-authored-by: nibarAhmed <[email protected]>
Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: maria-rcks <[email protected]>
only21mil and others added 28 commits November 1, 2026 22:01
… database after settle, snooze or title updates (pingdotgg#28301)

Co-authored-by: Claude Opus 5.5 <[email protected]>
# Conflicts:
#	apps/server/src/orchestration-v2/RuntimePolicy.test.ts
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 8a892f5.

This comment will update automatically after the next completed run.

Copy link
Copy Markdown
Owner Author

CI run 41375689914 never ran on 8a892f5: all 17 jobs were cancelled after 24h queued on blacksmith-* runners, which this fork lacks. Not this PR's failure; it needs runner config, outside this PR.

Against upstream main (05c0ed7), the net diff is still just the fix: AntigravityProvider.ts, its test, and the added RuntimePolicy.test.ts case. The 4,984 files shown here come from this fork's main being behind upstream.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.