Add Web Feature to Subxt Codegen #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Sep 25, 2023
lexnv
approved these changes
Sep 25, 2023
Collaborator
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
Nice! Looks good and should be ready for merge after the compile_error! fix 👍
* metadata: Extend outer enum generation for V14 Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Generate outer enums if not present Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Porpagate v14 error instead of panic Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Try to find `RuntimeCall` then `Call` enums Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Ensure the returned type is variant for outer enums Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Replace or with or_else Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Apply clippy Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Return error and generate only `RuntimeError` Signed-off-by: Alexandru Vasile <[email protected]> * metadata: Remove modified path Signed-off-by: Alexandru Vasile <[email protected]> * metadata/tests: Check missing runtime types Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
approved these changes
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1169