This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Change companion check order #8460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently if the pr isn't approved it counts as not mergable. However, this is rahter confusing. To fix this, we just change the order.
bkchr
added
A2-insubstantial
shawntabrizi
added
the
C1-low
TriplEight
approved these changes
Mar 26, 2021
gui1117
approved these changes
Mar 26, 2021
gui1117
reviewed
Mar 26, 2021
| curl -H "${github_header}" -sS -o companion_pr.json \ | ||
| ${github_api_polkadot_pull_url}/${pr_companion} | ||
|
|
||
| pr_head_sha=$(jq -r -e '.head.sha' < companion_pr.json) |
Contributor
There was a problem hiding this comment.
ah but this varialbe is used above, line 68
Merged
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* Change companion check order Apparently if the pr isn't approved it counts as not mergable. However, this is rahter confusing. To fix this, we just change the order. * Move exit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently if the pr isn't approved it counts as not mergable. However,
this is rahter confusing. To fix this, we just change the order.