This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Verify the storage root and tx trie root in runtime #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor `TestExternalities` into a single place.
Also refactor wasm exports to be stricter on invalid mem references.
gavofyork
changed the title
gavofyork
commented
Jan 31, 2018
| ext_enumerated_trie_root(values_data: *const u8, values_len: u32, lens_data: *const u32, lens_len: u32, result: *mut u8) => { | ||
| let values = (0..lens_len) | ||
| .map(|i| this.memory.read_primitive(lens_data + i * 4)) | ||
| .collect::<::std::result::Result<Vec<u32>, DummyUserError>>()? |
Member
Author
There was a problem hiding this comment.
anyone know of any better way of shortcircuiting a Result than .collect()?.into_iter()?
Member
There was a problem hiding this comment.
arkpar
reviewed
Jan 31, 2018
| } | ||
| })() | ||
| let mut sig = [0u8; 64]; | ||
| this.memory.get_into(sig_data, &mut sig[..]).map_err(|_| DummyUserError)?; |
Member
There was a problem hiding this comment.
Previous version preserved error code here. Is it intentionally discarded now?
Member
Author
There was a problem hiding this comment.
yup - any attempt to read out of bounds memory is now a strict runtime error.
arkpar
approved these changes
Jan 31, 2018
This was referenced Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API only works with our in-memory stuff, but that's fine for PoC-1. We'll need to rethink this for PoC-2 when we have a more serious backend.
Closes #37
Closes #39