This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Introduce safe types for handling imbalances #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
reviewed
Mar 20, 2019
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
Looks really good now, much clearer for me.
pepyakin
reviewed
Mar 20, 2019
joepetrowski
previously requested changes
Mar 20, 2019
gui1117
reviewed
Mar 20, 2019
pepyakin
reviewed
Mar 20, 2019
contracts module can never create cash.
rphmeier
approved these changes
Mar 20, 2019
rphmeier
added
A8-looksgood
and removed
A0-please_review
This was referenced Mar 20, 2019
Closed
Merged
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Be a little safer with total issuance. * PairT instead of _Pair * Remove rev causing upset * Remove fees stuff. * Fix build (including tests) * Update runtime, bump version * Fix * Handle gas refunds properly. * Rename identifier ala paritytech#2025 * Address grumbles * New not-quite-linear-typing API * Slimmer API * More linear-type test fixes * Fix tests * Tidy * Fix some grumbles * Keep unchecked functions private * Remove another less-than-safe currency function and ensure that contracts module can never create cash. * Address a few grumbles and fix tests
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2028
This introduces a new funky type
Imbalance, which is move-only and wannabe Linear. You get one back whenever you alter a balance in a one-sided way (deposit, slash, withdraw, ...). By default when it gets dropped it'll square things up regarding the module it comes from (for balances, it will update the total issuance), but you can also split it and cancel it out with other opposing operations.