Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@koushiro
Copy link
Contributor

Close #12248

@koushiro
Copy link
Contributor Author

@bkchr @KiChjang @kianenigma PTAL

@KiChjang
Copy link
Contributor

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

@koushiro
Copy link
Contributor Author

koushiro commented Sep 23, 2022

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

I have no particular preference for deleting or deprecating decl_* macros, and both are fine for me.

But I don't know what other people think, whether the macros need to deprecated firstly, and then remove it in a later version ?

@bkchr
Copy link
Member

bkchr commented Sep 23, 2022

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

We can open a forum thread in Polkadot forum and make some poll. I don't know if someone is may still using them.

@shawntabrizi
Copy link
Member

Let's just remove it.

We have plenty of documentation on how to migrate, and we really should encourage people to switch over if they have not.

@koushiro
Copy link
Contributor Author

Let's just remove it.

We have plenty of documentation on how to migrate, and we really should encourage people to switch over if they have not.

Okay, I will open another PR to remove it.

@kianenigma
Copy link
Contributor

Seems like we will see a new PR, so I will close this one. Please reopen if otherwise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Deprecation] Deprecate decl_* macros

5 participants