-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Deprecate decl_* macros
#12326
Deprecate decl_* macros
#12326
Conversation
Signed-off-by: koushiro <[email protected]>
Signed-off-by: koushiro <[email protected]>
|
@bkchr @KiChjang @kianenigma PTAL |
Signed-off-by: koushiro <[email protected]>
|
Actually, I don't think we should simply deprecate at this point -- we should just remove all of these |
I have no particular preference for deleting or deprecating But I don't know what other people think, whether the macros need to deprecated firstly, and then remove it in a later version ? |
Signed-off-by: koushiro <[email protected]>
We can open a forum thread in Polkadot forum and make some poll. I don't know if someone is may still using them. |
|
Let's just remove it. We have plenty of documentation on how to migrate, and we really should encourage people to switch over if they have not. |
Okay, I will open another PR to remove it. |
|
Seems like we will see a new PR, so I will close this one. Please reopen if otherwise. |
Close #12248