Bonded fund cannot be used for transaction payment but comments said otherwise

Previously, bonded fund can be used for transaction payment so it is OK to bond all the funds and still be able to make transaction to unbond them. This is no longer possible after #3606 but the comments still says `The lock will lock the entire funds except paying for further transactions. `

https://github.com/paritytech/substrate/blob/70f1d8d968f374f09b395420901c0926a2d874f7/frame/staking/src/lib.rs#L1272-L1286

With `WithdrawReason::Tip`, it should be safe to allow `TransactionPayment` reason and https://github.com/paritytech/substrate/pull/3364#discussion_r313806640 no longer applies.


	/// Update the ledger for a controller. This will also update the stash lock. The lock will
	/// will lock the entire funds except paying for further transactions.
	fn update_ledger(
	controller: &T::AccountId,
	ledger: &StakingLedger<T::AccountId, BalanceOf<T>>
	) {
	T::Currency::set_lock(
	STAKING_ID,
	&ledger.stash,
	ledger.total,
	T::BlockNumber::max_value(),
	WithdrawReasons::all(),
	);
	<Ledger<T>>::insert(controller, ledger);
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bonded fund cannot be used for transaction payment but comments said otherwise #4616

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Bonded fund cannot be used for transaction payment but comments said otherwise #4616

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions