Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

OnUnbalanced triggers even when zero #4088

@emielsebastiaan

Description

@emielsebastiaan

In a recent runtime upgrade (Kusama) the treasury.Deposit-event was added.
This event is triggered quite frequently: https://polkascan.io/pre/kusama-cc2/event?module=treasury&event=Deposit&page=1

Most instances of the event have a zero value; Examples:

It looks like only the events that are triggered at the end of a session have a non-zero value; Examples:

  1. End of session: 257
  1. End of session: 256

I have the following questions/remarks:

  1. Why are some of those events triggered mid-session?
  2. Why do those mid-session events have a zero value?
  3. Shouldn't these mid-session events simply be omitted (bloat/no added value)?
  4. Why are there 2 such events at the end of the session?
  5. If these 2 events have distinct meaning, shouldn't it be two distinct event types?
  6. If they do not have a distinct meaning, why not combine these two events into one event with a combined value?

Metadata

Metadata

Assignees

Labels

I4-annoyanceThe client behaves within expectations, however this “expected behaviour” itself is at issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions