This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
OnUnbalanced triggers even when zero #4088
Copy link
Copy link
Closed
Labels
I4-annoyanceThe client behaves within expectations, however this “expected behaviour” itself is at issue.The client behaves within expectations, however this “expected behaviour” itself is at issue.
Description
In a recent runtime upgrade (Kusama) the treasury.Deposit-event was added.
This event is triggered quite frequently: https://polkascan.io/pre/kusama-cc2/event?module=treasury&event=Deposit&page=1
Most instances of the event have a zero value; Examples:
- https://polkascan.io/pre/kusama-cc2/event/582836-3
- https://polkascan.io/pre/kusama-cc2/event/582808-3
It looks like only the events that are triggered at the end of a session have a non-zero value; Examples:
- End of session: 257
- https://polkascan.io/pre/kusama-cc2/event/582742-4 (~0.18 KSM)
- https://polkascan.io/pre/kusama-cc2/event/582742-6 (~260.882 KSM)
- End of session: 256
- https://polkascan.io/pre/kusama-cc2/event/580733-3 (~32.103 KSM)
- https://polkascan.io/pre/kusama-cc2/event/580733-5 (~260.838 KSM)
I have the following questions/remarks:
- Why are some of those events triggered mid-session?
- Why do those mid-session events have a zero value?
- Shouldn't these mid-session events simply be omitted (bloat/no added value)?
- Why are there 2 such events at the end of the session?
- If these 2 events have distinct meaning, shouldn't it be two distinct event types?
- If they do not have a distinct meaning, why not combine these two events into one event with a combined value?
Metadata
Metadata
Assignees
Labels
I4-annoyanceThe client behaves within expectations, however this “expected behaviour” itself is at issue.The client behaves within expectations, however this “expected behaviour” itself is at issue.