Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Unsigned transactions not validated during Executive::apply_extrinsic #3091

@tomusdrw

Description

@tomusdrw

It seems that while you can't propagate incorrect unsigned transaction cause it won't be accepted to the pool you can still craft a block with bullshit and it's going to be processed just fine.

We should add a call to validate_unsigned in case we detect the extrinsic is unsigned transaction in apply_extrinsic and check that it returns TransactionValidity::Valid.

Alternatively the UnsignedValidator should have two different methods, where one is called during validate_transaction and second during apply_extrinsic phase. For convenience we can have a default implementation for the latter to just check for TransactionValidity::Valid.

Metadata

Metadata

Assignees

No one assigned

    Labels

    I3-bugThe node fails to follow expected behavior.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions