Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

decl_module! allow procedural macro to work on calls function #2782

@gui1117

Description

@gui1117

Currently we only provide doc attribute for dispatchable call.

But some module maker could want to add more logic make use of procedural macros.

Would it be interesting to allow this users to make use of regular attribute ?

Pros:

  • User can make use of procedural macros to add logic on calls in a very efficient way.

Cons:

  • This expose our implementation into some kind of APIs, the way we implemented this distpatchable function would now be constrained because some user have macros that expect previous result.
  • This is quite touchy in regards to what we auto-generate like Ok(()) for instance.

Finally I feel not in favor of it considering the potential complexity it brings in regards to backward compatibility and APIs.

@gautamdhameja
@bkchr ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Z7-questionIssue is a question. Closer should answer.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions