Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Staking reward could potentially overflow #1572

Closed
Closed
Staking reward could potentially overflow#1572
Assignees
gui1117Demi-Marie
Labels
I3-bugThe node fails to follow expected behavior.
Milestone
Ideas
@gnunicorn

Description

@gnunicorn
gnunicorn
opened on Jan 25, 2019

Look here:

substrate/srml/staking/src/lib.rs

Lines 356 to 359 in bbe1816

let total = noms.iter().map(<balances::Module<T>>::total_balance).fold(T::Balance::zero(), |acc, x| acc + x);
if !total.is_zero() {
let safe_mul_rational = |b| b * rem / total;// FIXME: avoid overflow
for n in noms.iter() {

substrate/srml/staking/src/lib.rs

Lines 378 to 380 in bbe1816

.max(One::one());
let safe_mul_rational = |b| b * reward / total;// FIXME: avoid overflow
for n in noms.iter() {

Metadata

Metadata

Assignees

Labels

I3-bugThe node fails to follow expected behavior.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions