Is there a particular reason we are not creating a dedicated error value named PalletNotIncluded rather than adding comments?

Could you elaborate the rationale behind implementing the mmr API which only errors rather than omitting the implementation entirely? Where does the requirement having that trait in the runtime stem from, for those where it'd be error only?

Could you elaborate the rationale behind implementing the mmr API which only errors rather than omitting the implementation entirely? Where does the requirement having that trait in the runtime stem from, for those where it'd be error only?

@andresilva or @tomusdrw might have the full context, but I believe BEEFY+MMR were previously deployed on all chains, then decided to be disabled and reworked, but the APIs kept in the runtimes for compatibility maybe?

I believe the thinking was they'd be relatively quickly re-enabled.

Right now, the timeline for BEEFY+MMR to reach Polkadot is end of this year with Kusama sooner.

If we remove the stubs now, and re-add them as fully functional APIs later would we need runtime upgrades? Not sure how big the hassle is and if it's worth it...

@Wizdave97 please pull in latest polkadot/master

@paritytech/polkadot-review runtime files are touched with trivial change, but 2 approvals from you are required nevertheless.

@paritytech/polkadot-review runtime files are touched with trivial change, but 2 approvals from you are required nevertheless.

Merged the latest changes, can't seem to request reviews from the other required reviewers

CI still stumbles upon some of the changes (did not dig into it yet). I'll bug more reviewers once that's achieved.

CI still stumbles upon some of the changes (did not dig into it yet). I'll bug more reviewers once that's achieved.

Makes sense.

Right now, the PR is as green as it can get for a companion.
The substrate PR, for which this is a companion, is 100% green: paritytech/substrate#10635

CI still stumbles upon some of the changes (did not dig into it yet). I'll bug more reviewers once that's achieved.

As a non-frequent companion user, I mixed things, that's not possible. Pinged people to review.

The required approves set is kinda tight:

usersToAskForReview Map(4) {
  'gavofyork' => { teams: Set(1) { 'locks-review' } },
  'shawntabrizi' => { teams: Set(1) { 'locks-review' } },
  'bkchr' => { teams: Set(1) { 'locks-review' } },
  'rphmeier' => { teams: Set(1) { 'locks-review' } }
}

@paritytech/locks-review please take a look, changes are trivial at the runtime level.

Waiting for commit status.

Merge cancelled due to error. Error: Statuses failed for b4523fe

bot merge

Waiting for commit status.