Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for Remove the service builder #1448

Merged
expenses merged 13 commits into from
Jul 23, 2020
Merged

Companion PR for Remove the service builder #1448

expenses merged 13 commits into from
Jul 23, 2020

Conversation

@expenses
Copy link
Contributor

@expenses expenses commented Jul 21, 2020

@expenses expenses added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Jul 21, 2020
@expenses expenses requested review from bkchr, cecton and seunlanlege July 21, 2020 15:02
@expenses expenses mentioned this pull request Jul 21, 2020
Merged
seunlanlege
seunlanlege reviewed Jul 22, 2020
View reviewed changes
rphmeier
rphmeier reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let client team review this one. But the service-new crate needs the same update, I'd assume

@expenses expenses requested review from rphmeier and seunlanlege July 22, 2020 13:03
ordian
ordian reviewed Jul 22, 2020
View reviewed changes
@rphmeier
Copy link
Contributor

rphmeier commented Jul 22, 2020

(won't be reviewing this one)

@ghost
Copy link

ghost commented Jul 22, 2020

Failed updating substrate.

@sorpaas sorpaas mentioned this pull request Jul 23, 2020
Merged
@ordian ordian added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Jul 23, 2020
@expenses expenses merged commit fe00c79 into master Jul 23, 2020
@expenses expenses deleted the ashley-remove-service-builder branch July 23, 2020 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bkchr bkchr Awaiting requested review from bkchr

@rphmeier rphmeier Awaiting requested review from rphmeier

@seunlanlege seunlanlege Awaiting requested review from seunlanlege

2 more reviewers

@cecton cecton cecton approved these changes

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@expenses @rphmeier @cecton @ordian @seunlanlege @paritytech-ci