Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for https://github.com/paritytech/substrate/pull/6400 #1287

Merged
gavofyork merged 5 commits into from
Jun 23, 2020
Merged

Companion PR for https://github.com/paritytech/substrate/pull/6400 #1287

gavofyork merged 5 commits into from
Jun 23, 2020

Conversation

@cecton
Copy link
Contributor

@cecton cecton commented Jun 19, 2020 •
edited
Loading

cecton added 2 commits June 19, 2020 08:47
@cecton
Initial commit
0bab763 
Forked at: f351f42
Parent branch: origin/master
@cecton
Substrate companion PR
7b5ac3e 
impl Debug for sc_service::Configuration

Related to: paritytech/substrate#6400
@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jun 19, 2020
@cecton cecton marked this pull request as ready for review June 19, 2020 11:33
@cecton cecton self-assigned this Jun 19, 2020
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jun 19, 2020
@cecton cecton added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. and removed A0-please_review Pull request needs code review. labels Jun 19, 2020
@cecton cecton mentioned this pull request Jun 19, 2020
Merged
@gavofyork gavofyork added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Jun 22, 2020
@gavofyork gavofyork added A9-companion-backlog and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. labels Jun 23, 2020
@gavofyork gavofyork merged commit 1cd96bb into master Jun 23, 2020
@gavofyork gavofyork deleted the cecton-service-config-debug branch June 23, 2020 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gavofyork gavofyork gavofyork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cecton cecton

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cecton @gavofyork