Ingore dev and build dependencies in feature checking #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cargo resolver 2, features enabled in build or dev dependencies are not merged anymore with the normal dependencies. So, for our script here we should also only enable normal dependencies.
joao-paulo-parity
approved these changes
Dec 12, 2022
Contributor
There was a problem hiding this comment.
I don't know what the script is supposed to validate exactly, so I don't know if this PR aligns with the script's intentions. Implementation-wise this PR looks good. features,normal is documented in https://github.com/rust-lang/cargo/blob/62b6d5a112fb500bfeefd62d15c421b82bd233fb/src/doc/man/cargo-tree.md#tree-options FWIW.
ggwpez
approved these changes
Dec 12, 2022
sergejparity
approved these changes
Dec 12, 2022
mordamax
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cargo resolver 2, features enabled in build or dev dependencies are not merged anymore with the normal dependencies. So, for our script here we should also only enable normal dependencies.