Speed up hex serialization and fix warnings#208
Merged
Conversation
|
It looks like @demimarie-parity hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
This uses unsafe code (with a proof of safety) to speed up serialization. It also fixes a warning due to a deprecated `...` range pattern.
Demi-Marie
force-pushed
the
demi/speedup-and-fix-warnings
branch
from
1b5f2e0 to
a31c433
Compare
niklasad1
reviewed
Sep 2, 2019
niklasad1
reviewed
Sep 2, 2019
dvdplm
reviewed
Sep 2, 2019
tomusdrw
reviewed
Sep 2, 2019
ordian
approved these changes
Sep 2, 2019
ordian
left a comment
ordian
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but comments need to be updated.
Co-Authored-By: Andronik Ordian <[email protected]>
tomusdrw
reviewed
Sep 2, 2019
tomusdrw
approved these changes
Sep 2, 2019
Deserializing an unbounded, untrusted input stream is generally a DoS vulnerability anyway, even with Serde. So this is not normally exploitable.
ordian
added a commit
that referenced
this pull request
Sep 5, 2019
* master: [plain_hasher] Migrate to 2018 edition (#213) [ethbloom] Improve ethbloom (#215) [rlp] fix nested unbounded lists (#203) stabilize parity-bytes in no_std environment (#212) Speed up hex serialization, support Serde `with`, and fix warnings (#208) [ethbloom, ethereum-types,kvdb] migrate to 2018 edition (#205) Introduce `ContractAddress` newtype instead of scheme enum (#200)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses unsafe code (with a proof of safety) to speed up
serialization. It also fixes a warning due to a deprecated
...rangepattern.