uint: faster div#126
Merged
Merged
Conversation
dvdplm
reviewed
Apr 23, 2019
ordian
force-pushed
the
ao-then-get-ready-for-the-fast-div
branch
from
7483568 to
1cba3d2
Compare
ordian
force-pushed
the
ao-then-get-ready-for-the-fast-div
branch
from
1cba3d2 to
cb3794d
Compare
ordian
force-pushed
the
ao-then-get-ready-for-the-fast-div
branch
from
cb3794d to
e81af20
Compare
tomusdrw
approved these changes
May 4, 2019
dvdplm
approved these changes
May 6, 2019
Merged
* master: uint: faster mul by u64 (#125) fix rocksdb block cache size (#122) uint: convert benchmarks to criterion (#123) Bump fixed-hash to 0.3.2 (#134) Use EntropyRng instead of OsRng (#130) Bump parity-crypto to 0.3.1 (#132) rust-crypto dependency removal (#85) Use newly stablized TryFrom trait for primitive-types (#127)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on top of #125 (commits since 8d0e7cd only)
changes:
div_modmethoddiv_mod(comparison with gmp) anddiv_mod_word(u128 / u64, u128 % u64)divandmodtodiv_modBy using division algorithm from TAOCP by Knuth, we're now almost as fast as GMP in the worst case 🎉
(GMP is still faster when the divisor is small, but that's not the worst case anymore)
bench results
Note, that performance of
div/remhas regressed in some cases.