This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove av-store, av-distribution, chain-api subsystems from minimal node #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
B0-silent
altonen
approved these changes
Nov 24, 2022
bkchr
reviewed
Nov 24, 2022
| let (collation_req_receiver, available_data_req_receiver, pov_req_receiver, chunk_req_receiver) = | ||
| let (collation_req_receiver, available_data_req_receiver, chunk_req_receiver) = | ||
| build_request_response_protocol_receivers(&request_protocol_names, &mut config); | ||
| drain_unwanted_request_channels(&task_manager, chunk_req_receiver); |
Member
There was a problem hiding this comment.
Okay, this is unneeded. We can not do two things. Either we drop this channel or we do not even register the channel.
Comment on lines
245
to
246
| let (chunk_req_receiver, cfg) = IncomingRequest::get_config_receiver(request_protocol_names); | ||
| config.network.request_response_protocols.push(cfg); |
Member
There was a problem hiding this comment.
Suggested change
| let (chunk_req_receiver, cfg) = IncomingRequest::get_config_receiver(request_protocol_names); | |
| config.network.request_response_protocols.push(cfg); | |
| let (_, cfg) = IncomingRequest::get_config_receiver(request_protocol_names); | |
| // We don't support inbound requests for this protocol. | |
| let cfg = RequestResponseConfig { inbound_queue: None, ..cfg }; | |
| config.network.request_response_protocols.push(cfg); |
Member
There was a problem hiding this comment.
We should probably support this in Polkadot directly. When it is a collator/full node we should not register an incoming receiver
Contributor
Author
|
Waiting for paritytech/polkadot#6343, then we can remove the inbound channel. |
bkchr
approved these changes
Nov 27, 2022
Member
|
bot merge |
|
Waiting for commit status. |
devdanco
added a commit
to gasp-xyz/cumulus
that referenced
this pull request
Feb 14, 2023
This PR removes the following subsystems from the minimal node:
Originally I was under the impression that we need these for PoV-Recovery, but that is not the case.
We still need to register the chunk fetching protocol, since we send requests for this. Answering was done by
the availability-distribution subsystem, which is now removed. If we receive such a request we always send back
NoSuchChunkbecause we are guaranteed to not have it.