Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@muharem
Copy link
Contributor

@muharem muharem commented Nov 12, 2022

Companion for paritytech/polkadot#6273

@muharem muharem added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C3-medium PR touches the given topic and has a medium impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Nov 12, 2022
@paritytech-ci paritytech-ci requested review from a team November 12, 2022 11:26
@paritytech-ci paritytech-ci requested a review from a team November 24, 2022 07:30
@paritytech-ci paritytech-ci requested a review from a team November 25, 2022 06:47
@gilescope gilescope changed the title Companion: Accept Kusama StakinAdmin origin Companion: Accept Kusama StakingAdmin origin Nov 25, 2022
@the-right-joyce the-right-joyce added T1-runtime This PR/Issue is related to the topic “runtime”. and removed X1-runtime labels Dec 12, 2022
Copy link
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably make a new BodyId::TechnicalFellowship to avoid granting Fellowship power to the old Technical Committee.


parameter_types! {
// Fellows pluralistic body.
pub const FellowsBodyId: BodyId = BodyId::Technical;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that as long as the Tech Committee and Fellowship coexist, the Tech Comm would be able to control this origin.
https://github.com/paritytech/polkadot/pull/6273/files#r1049712864

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but this should be valid?
Tech Committee has a root permissions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they do not. Only fast tracking permission.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked, Technical xcm body not used/mapped right now in kusama or polkadot (only docs tells as its supposed to be used as Tech Comm), it's safe to start using it as Fellows.

@muharem
Copy link
Contributor Author

muharem commented Dec 21, 2022

bot rebase

@paritytech-processbot
Copy link

Rebased

@muharem
Copy link
Contributor Author

muharem commented Dec 22, 2022

bot rebase

@paritytech-processbot
Copy link

Rebased

@muharem
Copy link
Contributor Author

muharem commented Dec 22, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit bb26a82 into master Dec 22, 2022
@paritytech-processbot paritytech-processbot bot deleted the muharem-kusama-xcm-origins branch December 22, 2022 12:01
samelamin pushed a commit to samelamin/cumulus that referenced this pull request Jan 4, 2023
* Companion: Accept Kusamsa StakinAdmin origin

* Fellows origin for xcmp queue controller

* plurality bodies to ensure origin

* include root into controller ensure origin

* fix

* use xcm bodies

* rename to more frequent "defense"

Co-authored-by: parity-processbot <>
vieira-giulia pushed a commit that referenced this pull request Jan 17, 2023
* Companion: Accept Kusamsa StakinAdmin origin

* Fellows origin for xcmp queue controller

* plurality bodies to ensure origin

* include root into controller ensure origin

* fix

* use xcm bodies

* rename to more frequent "defense"

Co-authored-by: parity-processbot <>
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-37/1736/1

bkontur added a commit that referenced this pull request Feb 8, 2023
4c4a7eae1 Small stuff from Cumulus integration (#1865)

git-subtree-dir: bridges
git-subtree-split: 4c4a7eae1503aa63a84fb65d56d67599d362d645