Conversation
|
Disabled GHA for now, as we decided to wait with cross testing. |
drahnr
left a comment
There was a problem hiding this comment.
It's a good start, but I think we should try something a bit more sophisticated.
There are a lot of feature flags that guard certain tests dist-tests and we should also assure the we do not introduce cross dependencies between different features.
| <<: *docker-env | ||
| stage: test | ||
| variables: | ||
| EXTRA_FEATURES: "$EXTRA_FEATURES unstable" |
There was a problem hiding this comment.
What's the point of this inception? So that UI can inject features?
There was a problem hiding this comment.
I took it from travis config, assuming there was a reason for doing so.
|
This is in no way the final CI, just an initial one to lint the code and start merging some PRs. |
The image is temporary. Rust there is updated according to the latest known to support the listed components. Default is nightly.
Not sure if we need separate jobs for stable and nightly versions of Rust, just copied how it was on the upstream.
With the deployment I guess, it makes sense to wait until #7 gets merged.