Skip to content
This repository was archived by the owner on Feb 28, 2023. It is now read-only.

Comments

Initial ci#8

Merged
TriplEight merged 3 commits intomasterfrom
initial_ci
Nov 17, 2020
Merged

Initial ci#8
TriplEight merged 3 commits intomasterfrom
initial_ci

Conversation

@TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Nov 13, 2020

The image is temporary. Rust there is updated according to the latest known to support the listed components. Default is nightly.

Not sure if we need separate jobs for stable and nightly versions of Rust, just copied how it was on the upstream.

With the deployment I guess, it makes sense to wait until #7 gets merged.

@TriplEight TriplEight added the CI label Nov 13, 2020
@TriplEight TriplEight self-assigned this Nov 13, 2020
@TriplEight TriplEight requested a review from drahnr November 13, 2020 19:45
@TriplEight
Copy link
Contributor Author

Disabled GHA for now, as we decided to wait with cross testing.

Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, but I think we should try something a bit more sophisticated.

There are a lot of feature flags that guard certain tests dist-tests and we should also assure the we do not introduce cross dependencies between different features.

<<: *docker-env
stage: test
variables:
EXTRA_FEATURES: "$EXTRA_FEATURES unstable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this inception? So that UI can inject features?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from travis config, assuming there was a reason for doing so.

@TriplEight
Copy link
Contributor Author

This is in no way the final CI, just an initial one to lint the code and start merging some PRs.
There will be a setup for dist-config, but after we'll get rid of openssl, there are issues with using it here.

@TriplEight TriplEight merged commit 5fe0954 into master Nov 17, 2020
@TriplEight TriplEight deleted the initial_ci branch November 17, 2020 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants