This repository was archived by the owner on Feb 28, 2023. It is now read-only.
Merged
Conversation
Contributor
Author
|
Pending some unit tests to verify the results are equiv. |
Contributor
|
if you're waiting travis to be rewritten to gitlab, it kinda depends on this PR. |
Contributor
Author
|
This one depends on me writing some verification tests |
Merged
drahnr
force-pushed
the
bernhard-remove-openssl
branch
from
fceeda3 to
e93f973
Compare
drahnr
force-pushed
the
bernhard-remove-openssl
branch
from
5e54fce to
3f030f3
Compare
gww-parity
suggested changes
Nov 16, 2020
Contributor
gww-parity
left a comment
gww-parity
left a comment
There was a problem hiding this comment.
Regression in compiler warnings introduced with:
3f030f3
src/dist/http.rs
Outdated
| .to_owned(); | ||
|
|
||
| use picky::key::{PublicKey, PrivateKey}; | ||
| use picky::pem::{parse_pem, Pem}; |
Contributor
There was a problem hiding this comment.
warning: unused imports: `Pem`, `parse_pem`
--> src/dist/http.rs:308:22
|
308 | use picky::pem::{parse_pem, Pem};
| ^^^^^^^^^ ^^^
|
= note: `#[warn(unused_imports)]` on by default
src/dist/http.rs
Outdated
| use picky::pem::{parse_pem, Pem}; | ||
| use picky::{signature::SignatureAlgorithm, hash::HashAlgorithm}; | ||
| use picky::x509::key_id_gen_method::{KeyIdGenError, KeyIdGenMethod}; | ||
| use picky::x509::{certificate::CertType, csr::Csr}; |
Contributor
There was a problem hiding this comment.
warning: unused imports: `certificate::CertType`, `csr::Csr`
--> src/dist/http.rs:311:23
|
311 | use picky::x509::{certificate::CertType, csr::Csr};
| ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^
src/dist/http.rs
Outdated
| use picky::key::{PublicKey, PrivateKey}; | ||
| use picky::pem::{parse_pem, Pem}; | ||
| use picky::{signature::SignatureAlgorithm, hash::HashAlgorithm}; | ||
| use picky::x509::key_id_gen_method::{KeyIdGenError, KeyIdGenMethod}; |
Contributor
There was a problem hiding this comment.
warning: unused import: `KeyIdGenError`
--> src/dist/http.rs:310:42
|
310 | use picky::x509::key_id_gen_method::{KeyIdGenError, KeyIdGenMethod};
| ^^^^^^^^^^^^^
src/dist/http.rs
Outdated
| use picky::x509::certificate::CertificateBuilder; | ||
| use picky::x509::extension::ExtendedKeyUsage; | ||
| use picky::x509::extension::KeyUsage; | ||
| use picky::x509::Extension; |
Contributor
There was a problem hiding this comment.
warning: unused import: `picky::x509::Extension`
--> src/dist/http.rs:317:9
|
317 | use picky::x509::Extension;
| ^^^^^^^^^^^^^^^^^^^^^^
src/dist/http.rs
Outdated
| use picky::x509::extension::KeyUsage; | ||
| use picky::x509::Extension; | ||
| use picky::x509::Extensions; | ||
| use sha2::{Sha256, Sha512, Digest}; |
Contributor
There was a problem hiding this comment.
warning: unused imports: `Sha256`, `Sha512`
--> src/dist/http.rs:319:16
|
319 | use sha2::{Sha256, Sha512, Digest};
| ^^^^^^ ^^^^^^
src/dist/http.rs
Outdated
| use chrono::Datelike; | ||
| use chrono::Timelike; | ||
| use std::ops::DerefMut; | ||
| use std::convert::TryFrom; |
Contributor
There was a problem hiding this comment.
warning: unused import: `std::convert::TryFrom`
--> src/dist/http.rs:324:9
|
324 | use std::convert::TryFrom;
| ^^^^^^^^^^^^^^^^^^^^^
src/dist/http.rs
Outdated
| use chrono::Timelike; | ||
| use std::ops::DerefMut; | ||
| use std::convert::TryFrom; | ||
| use std::net::{IpAddr, Ipv4Addr, SocketAddr}; |
Contributor
There was a problem hiding this comment.
warning: unused import: `Ipv4Addr`
--> src/dist/http.rs:325:28
|
325 | use std::net::{IpAddr, Ipv4Addr, SocketAddr};
| ^^^^^^^^
gww-parity
approved these changes
Nov 17, 2020
Contributor
gww-parity
left a comment
gww-parity
left a comment
There was a problem hiding this comment.
Now I see no warnings and nice rustfmt on files. Thank you!
In future it will be highly appreciated if I could see rustfmt/style in separate commit, so commits with actual logical changes are easier to focus on.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.