Skip to content
This repository was archived by the owner on Feb 28, 2023. It is now read-only.

Comments

Fix compilation in futures branch when not using default features#36

Merged
Xanewok merged 4 commits intobernhard-futures-migrationfrom
igor-futures-fixes
Mar 27, 2021
Merged

Fix compilation in futures branch when not using default features#36
Xanewok merged 4 commits intobernhard-futures-migrationfrom
igor-futures-fixes

Conversation

@Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Mar 27, 2021

This was checked and tested with --no-default-features either alone or combined with a single storage backend feature (azure, s3 etc.)

@Xanewok
Copy link
Contributor Author

Xanewok commented Mar 27, 2021

@drahnr the change set is trivial and mostly just adds some skipped features/types that are required when not compiling with default features, so I'll just merge that and tick the relevant box in #31; feel free to undo that if there are remaining concerns wrt that.

@Xanewok Xanewok merged commit 0711f50 into bernhard-futures-migration Mar 27, 2021
@Xanewok Xanewok deleted the igor-futures-fixes branch March 27, 2021 23:55
@drahnr
Copy link
Contributor

drahnr commented Mar 29, 2021

👍 LGTM, will keep

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants