This repository was archived by the owner on Feb 28, 2023. It is now read-only.
Closed
Conversation
* change (CI): initial CI * change (CI): initial CI * change (CI): add clippy and allow failure
PRs labelled `autorebase:opt-in` will be rebased automatically after updates in `master`.
In order to avoid timestamp presence in static lib files, making them non-deterministic. alexcrichton/cc-rs@555e773 mozilla/sccache#197
* Fix some types when not using dist-client feature * Pull required features for Tokio 0.2 This fixes a `--no-default-features` build since other dependencies incidentally pulled the relevant features themselves. * Fix compilation when using only azure feature * Fix compilation when using only dist-server feature
Most notably prefer std::future::Future over futures::Future since the std variant is here to stay
Let's stick to the upstream version. We seem to only care about starting and keeping the child server process alive until the end of the function, prefer the std variant for simplicity and to avoid footguns such as `Runtime::enter` that we had to use here.
The async `get_dist_status` called `get_status` that was locally blocking in a freshly created `Runtime`. Instead, use the already present `Runtime` instead creating it from scratch and mark `get_status` appropriately as async.
The only reason that's there is because the compiler is too conservative and treats borrows as alive longer than they actually are (even with explicit `drop`). Work around that by creating an owned future instead, returned from the `resolve_proxied_executable`. It's worth noting that `async_trait` returns a `Pin<Box>`ed future with the 'async lifetime, where we have &'async self as the method receiver. Because of this, we manually construct the future ourselves with the 'static lifetime.
This was referenced Apr 6, 2021
Closed
This was referenced May 1, 2021
Contributor
Author
|
Superseeded by #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The giant PR with eventually atomic commits, providing a step by step migration with individually compilable commits.