Skip to content
This repository was archived by the owner on Feb 28, 2023. It is now read-only.

Comments

Handle signals in dist#139

Merged
montekki merged 2 commits intomasterfrom
fs-dist-graceful-shutdown
Jan 31, 2022
Merged

Handle signals in dist#139
montekki merged 2 commits intomasterfrom
fs-dist-graceful-shutdown

Conversation

@montekki
Copy link
Contributor

So things like this

dockerd[1568]: time="2022-01-31T16:46:04.931374692+03:00" level=info msg="Container 40020d6e4ddb45bd862ef06c3d97baba0071448bae343c2ec48c2d8e5e7cb42f failed to exit within 10 seconds of signal 15 - using the force"

Do not happen

@montekki montekki requested review from Xanewok and drahnr January 31, 2022 15:21
@Xanewok
Copy link
Contributor

Xanewok commented Jan 31, 2022

LGTM! A brief comment would be be great near the select on why we want to do that in the first place (except it being a good hygiene in general)

@montekki montekki merged commit 926ce5b into master Jan 31, 2022
@montekki montekki deleted the fs-dist-graceful-shutdown branch January 31, 2022 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants