Conversation
drahnr
force-pushed
the
bernhard-rename
branch
from
3b1ff67 to
b28d143
Compare
drahnr
force-pushed
the
bernhard-rename
branch
from
ae757f1 to
9874247
Compare
|
Hold on, I am almost done rebasing :) |
drahnr
force-pushed
the
bernhard-rename
branch
from
06e0bf0 to
05a9ca1
Compare
montekki
left a comment
montekki
left a comment
There was a problem hiding this comment.
I think that some renames from dist::Server to dist::Coordinator were wrong and should instead be to dist::Worker.
Xanewok
left a comment
Xanewok
left a comment
There was a problem hiding this comment.
Marked some yet unchaged mentions of server
|
The more I think about it, the more I realize how overloaded the term "server" is in the cachepot/sccache context :( This rename helps a lot but I'm still wondering if "coordinator" is a good choice here. Maybe we could use "daemon"? It's more recognizable in terms of build systems (e.g. Gradle, Buck, Bazel) and I think the benefits from being familiar with the terminology are bigger, even if our "daemon" can sometimes be ran on the foreground (not 100% technically correct). |
Co-authored-by: Igor Matuszewski <[email protected]>
|
The CI looks ok, I think that all review points have been addressed so merging now |
3 participants
Ref #132
Should be merged after #131 is merged, to avoid additional friction.