rouille -> warp by montekki · Pull Request #131 · paritytech/cachepot

montekki · 2021-12-20T13:53:36Z

Still a lot of work to do but I think that api will be compatible with old code.

Fixes #39

drahnr · 2022-01-03T13:22:37Z

I'll give this a spin at some point this week, other than that this is looks good to me and ready to be merged 🎉

drahnr · 2022-01-07T09:22:48Z

cachepot -s

yields

cachepot: error: failed to get stats from server
cachepot: caused by: Failed to send data to or receive data from server
cachepot: caused by: Failed to read response header
cachepot: caused by: failed to fill whole buffer

with the local dispatch ( or local server) logs:

[2022-01-07T09:32:46Z DEBUG cachepot::config] Attempting to read config file at "/home/bernhard/.config/cachepot/config"
[2022-01-07T09:32:46Z DEBUG cachepot::config] Couldn't open config file: failed to open file `/home/bernhard/.config/cachepot/config`
[2022-01-07T09:32:46Z INFO  cachepot::config] Using the default configuration.
[2022-01-07T09:32:46Z INFO  cachepot::server] start_server: port: 4226
[2022-01-07T09:32:46Z INFO  cachepot::server] No scheduler address configured, disabling distributed cachepot
[2022-01-07T09:32:46Z DEBUG cachepot::cache::cache] Trying Redis(redis://127.0.0.1:6379/7)
[2022-01-07T09:32:46Z INFO  cachepot::server] server started, listening on port 4226
[2022-01-07T09:32:49Z DEBUG cachepot::server] handle_client: get_stats
[2022-01-07T09:32:49Z ERROR cachepot::server] Failed to bind socket: Connection refused (os error 111)

montekki · 2022-01-07T11:58:26Z

Were all previously launched instances of daemonized cachepot killed beforehand?

drahnr · 2022-01-07T13:04:27Z

Were all previously launched instances of daemonized cachepot killed beforehand?

Double checked:

After running sudo systemctl restart cachepot-server.service cachepot-scheduler.service; sudo pkill cachepot; ps ax | rg cachepot with only the rg process itself, same result.

Imho this error message is a bug in itself, it provides insufficient context: [2022-01-07T09:32:49Z ERROR cachepot::server] Failed to bind socket: Connection refused (os error 111)

montekki · 2022-01-07T13:07:28Z

Damn, I cant repro and i didn't even touch src/server.rs (i think)

montekki · 2022-01-07T13:08:48Z

Can you CACHEPOT_LOG=trace?

montekki · 2022-01-07T13:17:03Z

Also, I've run into ufw blocking connects

drahnr · 2022-01-07T13:34:40Z

I think my local redis just crashed and this is a side effect of it. I'll try to fix the instance, and open an issue regarding error handling of the backend if this is resolved.

Xanewok · 2022-01-07T13:53:21Z

cachepot -s

yields
<error>

I can't repro, I'm getting regular stat dump using this branch

drahnr · 2022-01-07T13:58:20Z

After fixing redis, the output is as expected.

src/util.rs

Xanewok

Excited for this change! 🎉 Looks good at a glance, I'll dig deeper later on since I had a hard time following the logic bundled together in a single file

src/dist/http.rs

Xanewok · 2022-01-07T13:58:36Z

src/dist/http.rs

+        }
+    }
+
+    mod scheduler_api_v1 {


Maybe it'd makes to extract API routes/logic to separate files?

I would suggest in another changeset.

Xanewok · 2022-01-07T13:59:34Z

src/dist/http.rs

+
+        impl warp::reject::Reject for Error {}
+
+        pub(super) mod filters {


ditto wrt modules

Xanewok · 2022-01-07T13:59:44Z

src/dist/http.rs

+            }
+        }
+
+        pub(super) mod handlers {


montekki · 2022-01-10T09:36:27Z

Merged this since it is blocking all stuff that needs to be done on top of it. In case there (most likely) be fallout lets deal with it iteratively in new issues.

Initial commit

60fb4ad

montekki changed the title ~~Initial commit~~ rouille -> warp Dec 20, 2021

Merge branch 'master' into fs-remove-rouille

767c39a

drahnr mentioned this pull request Dec 21, 2021

rename internal components #134

Merged

montekki added 14 commits December 22, 2021 13:41

A bit more errors

a8453bb

clippy

b3d610f

more clippy

d72f70f

No default dist-server

0e92f71

more async cod

afa0028

remove all blocking reqwests

cc100a0

fmt

98fb64e

Fix content types and test harness

9e3922e

maybe green ci

173e51c

bump timeout a bit and create a client only once

1f6c2ea

remove unused code

9080857

make thiserror optional

992986c

bring back void

20a5beb

do not change CI docker script

aa15fac

montekki marked this pull request as ready for review December 28, 2021 10:17

montekki added 6 commits December 28, 2021 17:51

fork is not async friendly

8fa3199

async bind

d36aba6

fmt

bb2808e

more fixes

ea3d7b4

async handle_assign_job

6a53d4e

async basic_compile

be34303

montekki added 2 commits January 6, 2022 11:13

minor fixes

342a08e

fmt

008c397

drahnr reviewed Jan 7, 2022

View reviewed changes

src/util.rs Show resolved Hide resolved

drahnr approved these changes Jan 7, 2022

View reviewed changes

Xanewok reviewed Jan 7, 2022

View reviewed changes

Adds a comment on native-tls

252452a

montekki merged commit 943fc53 into master Jan 10, 2022

montekki deleted the fs-remove-rouille branch January 10, 2022 09:35

Xanewok mentioned this pull request Feb 5, 2022

Prune openssl #87

Open

drahnr mentioned this pull request Feb 27, 2023

Port remaining cachepot changesets mozilla/sccache#1620

Open

5 tasks

drahnr mentioned this pull request May 18, 2023

Rm dep openssl mozilla/sccache#1742

Closed

Saruniks mentioned this pull request Jul 25, 2024

Replace rouille with axum mozilla/sccache#2234

Open

Saruniks mentioned this pull request Aug 2, 2024

Replace rouille with warp mozilla/sccache#2241

Open


		impl warp::reject::Reject for Error {}

		pub(super) mod filters {

Comments

Conversation

montekki commented Dec 20, 2021

Uh oh!

drahnr commented Jan 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

drahnr commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

montekki commented Jan 7, 2022

Uh oh!

drahnr commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

montekki commented Jan 7, 2022

Uh oh!

montekki commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

montekki commented Jan 7, 2022

Uh oh!

drahnr commented Jan 7, 2022

Uh oh!

Xanewok commented Jan 7, 2022

Uh oh!

drahnr commented Jan 7, 2022

Uh oh!

Uh oh!

Xanewok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Xanewok Jan 7, 2022

Choose a reason for hiding this comment

Uh oh!

montekki Jan 7, 2022

Choose a reason for hiding this comment

Uh oh!

Xanewok Jan 7, 2022

Choose a reason for hiding this comment

Uh oh!

Xanewok Jan 7, 2022

Choose a reason for hiding this comment

Uh oh!

montekki commented Jan 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

drahnr commented Jan 3, 2022 •

edited

Loading

drahnr commented Jan 7, 2022 •

edited

Loading

drahnr commented Jan 7, 2022 •

edited

Loading

montekki commented Jan 7, 2022 •

edited

Loading