Repository navigation
Fix bare except clauses in agent.py, channel.py, client.py, and transport.py - #2644
Open
koteshyelamati wants to merge 4 commits into
Open
koteshyelamati wants to merge 4 commits into
koteshyelamati wants to merge 4 commits into
Conversation
Refine exception handling to catch specific exceptions instead of all exceptions.
Change bare except to catch specific Exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 6 bare
except:clauses that catchBaseException(includingSystemExit,KeyboardInterrupt), replacing them withexcept Exception:or more specific types.paramiko/agent.py(3 instances):except:→except Exception:—_communicate()thread body; re-raises on failure.except:→except Exception:—_accept()socket accept; re-raises on failure.except:→except OSError:—conn.connect(SSH_AUTH_SOCK); comment says "probably a dangling env var: the ssh agent is gone", so onlyOSErroris expected.paramiko/channel.py(1 instance):except: pass→except Exception: pass— in__del__callingself.close(); standard cleanup.paramiko/client.py(1 instance):except: pass→except Exception: pass— aroundsock.settimeout(timeout).paramiko/transport.py(1 instance):except:→except Exception:— wraps transport run-loop teardown; conditionally re-raises if interpreter is still running.Bare
except:clauses are bad practice (PEP 8 / flake8 E722) because they swallowKeyboardInterruptandSystemExit.