Skip to content

cell plugin & pdf compression with Deflate & javascript plugin#75

Merged
MrRio merged 10 commits into
parallax:masterfrom
lifof:master
Mar 17, 2013
Merged

cell plugin & pdf compression with Deflate & javascript plugin#75
MrRio merged 10 commits into
parallax:masterfrom
lifof:master

Conversation

@lifof

@lifof lifof commented Mar 9, 2013

Copy link
Copy Markdown
Contributor

Cells and tables across pages.
Activate compression in pdf.
Embeded PDF JavaScript plugin.

@lifof

lifof commented Mar 11, 2013

Copy link
Copy Markdown
Contributor Author

@MrRio

MrRio commented Mar 11, 2013

Copy link
Copy Markdown
Member

Thanks for this :) I'll review this evening.

@lifof

lifof commented Mar 12, 2013

Copy link
Copy Markdown
Contributor Author

@lifof

lifof commented Mar 13, 2013

Copy link
Copy Markdown
Contributor Author

Hi

Please don't merge this code cause i found some bugs in the cell plugin, when creating a table starting from the bottom or middle of the page it will do the same for the other portions in the next pages, the code is messy but i'll get it to work and add some docs in the upcoming commits as soon as possible.

Thanks in advance
&
Have a great day

@MrRio

MrRio commented Mar 13, 2013

Copy link
Copy Markdown
Member

Thanks, I'll leave this Pull Request open to remind me.

Perhaps the API should be along the lines of:

var pdf = new jsPDF();
pdf.table(x, y, w, h, {
headers: ['one', 'two', 'three'],
content: [
['val', 'val', 'val'],
['row 2', 'etc', 'etc']
]
});

@lifof

lifof commented Mar 13, 2013

Copy link
Copy Markdown
Contributor Author

Thanks that's a great idea i'll work on it.

@lifof

lifof commented Mar 14, 2013

Copy link
Copy Markdown
Contributor Author

@lifof

lifof commented Mar 14, 2013

Copy link
Copy Markdown
Contributor Author

Hello

I think it's ok to merge now.Next addition will be the Table function.

Thanks again
&
Have a great day

innerdaze and others added 9 commits March 15, 2013 14:36
Added support for separate table header names & indexes
… as submodules.

Also replacing BlobBuilder.js with Blob.js
-Fixed some issues that broke cell fonctionnality.
-Added Opera and Safari browser check when saving pdf.
jspdf.js :
-Fixed Blob creation params.
Added check for Safari and Opera.
jspdf.plugin.cell.js & jspdf.plugin.javascript.js :
No more JSLint complains.
Fixed and Reordered some portions of code to be more JSLint friendly.
 - Fixed jsPDFAPI.getTextDimensions
@MrRio

MrRio commented Mar 17, 2013

Copy link
Copy Markdown
Member

Thanks, some really great fixes and changes in here.

No more asking about Safari or Opera
@lifof

lifof commented Mar 17, 2013

Copy link
Copy Markdown
Contributor Author

No problem this is also thanks to @lsdriscoll ^^

MrRio added a commit that referenced this pull request Mar 17, 2013
cell plugin & pdf compression with Deflate & javascript plugin
@MrRio
MrRio merged commit 13b4be8 into parallax:master Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants