Do not add pages dynamically unless autoPaging is enabled#3915
Merged
Conversation
HackbrettXXX
approved these changes
Oct 28, 2025
HackbrettXXX
left a comment
HackbrettXXX
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. Looks good.
Contributor
Author
|
@HackbrettXXX thanks for merging! Do you have any plans on when the new version might be published to npm? |
Collaborator
|
I'll wait until all Hacktober PRs have been merged. So probably around mid November. |
heikofolkerts
pushed a commit
to heikofolkerts/jsPDF-UA
that referenced
this pull request
Dec 11, 2025
Upstream changes: - Fix Context2d font regex (parallax#3906) - Fix autoPaging in Context2d (parallax#3915) - Fix TypeScript Margins interface (parallax#3816) - Bump GitHub Actions versions (parallax#3907) - Version bump to 3.0.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not add pages dynamically unless autoPaging is enabled
🐛 Problem
JsPDF might add a blank page in advance even if
autoPagingoption is not enabled.The reason is that some branches of autoPaging-related logic are executed despite the
autoPagingoption.✅ Solution
autoPagingoption.🧪 Pre-push checks
npm run buildpassesnpm run test-unitpassesnpm run test-localpassesnpm run lintpasses