Fix pages property to always return current array reference ( #3898 )#3899
Merged
HackbrettXXX merged 3 commits intoOct 7, 2025
Merged
Conversation
…x#3898 ) Previously, the pages array reference was exposed directly, which caused issues when the internal reference changed. Using a getter ensures that the current pages array is always returned.
HackbrettXXX
requested changes
Oct 7, 2025
HackbrettXXX
left a comment
HackbrettXXX
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Please run prettier to fix the linter complaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the pages array reference was exposed directly, which caused issues when the internal reference changed. Using a getter ensures that the current pages array is always returned.
fixes #3898