Skip to content

Fix font state management issue #3890#3891

Merged
HackbrettXXX merged 3 commits into
parallax:masterfrom
srikanth-s2003:fix/font-state-management-issue-3890
Oct 7, 2025
Merged

Fix font state management issue #3890#3891
HackbrettXXX merged 3 commits into
parallax:masterfrom
srikanth-s2003:fix/font-state-management-issue-3890

Conversation

@srikanth-s2003

@srikanth-s2003 srikanth-s2003 commented Sep 23, 2025

Copy link
Copy Markdown
Contributor
  • Fixed font face map caching in context2d module
  • Font face map now properly rebuilds when font list changes
  • Resolves issue where custom fonts fail to render after being interrupted by default fonts
  • Maintains performance through intelligent cache invalidation

Fixes #3890

@HackbrettXXX

Copy link
Copy Markdown
Collaborator

Please add a test case.

- Fixed font face map caching in context2d module
- Font face map now properly rebuilds when font list changes
- Resolves issue where custom fonts fail to render after being interrupted by default fonts
- Maintains performance through intelligent cache invalidation

Fixes parallax#3890
- Added test case to verify font face map cache invalidation
- Test ensures that font changes after adding new fonts work correctly
- Addresses reviewer feedback requesting test coverage
@srikanth-s2003
srikanth-s2003 force-pushed the fix/font-state-management-issue-3890 branch from 314e5c6 to ccc889b Compare October 6, 2025 12:22

@HackbrettXXX HackbrettXXX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks

@HackbrettXXX
HackbrettXXX merged commit 2db3d9d into parallax:master Oct 7, 2025
7 checks passed
Opineppes pushed a commit to Opineppes/jsPDF that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

html(): Custom font does not get set again if it has already been added once

2 participants