fix: Aggregate custom scan handles NULL bool values in GROUP BY#4584
Merged
rebasedming merged 1 commit into0.22.xfrom Mar 30, 2026
Merged
fix: Aggregate custom scan handles NULL bool values in GROUP BY#4584rebasedming merged 1 commit into0.22.xfrom
NULL bool values in GROUP BY#4584rebasedming merged 1 commit into0.22.xfrom
Conversation
…4582) # Ticket(s) Closed - Closes # ## What - `GROUP BY` on a nullable bool column with the aggregate custom scan crashed with: `InvalidArgument("Missing value U64(2) for field ... is not supported for column type Bool")` - The cause was that Tantivy's terms aggregation rejects all numeric `Key` variants for Bool columns - Instead, use `Key::Str(NULL_SENTINEL_*)` for Bool fields, which routes through Tantivy's `MissingTermAgg` collector ## Why ## How ## Tests Added regression test --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]> (cherry picked from commit 99b6ddf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4582 to
0.22.x.