fix: rebuild custom scan heap state on rescan#4461
Merged
philippemnoel merged 1 commit into0.22.xfrom Mar 23, 2026
Merged
Conversation
## Summary - add a pg_test that reuses a stale ctid after the heap relation shrinks, reproducing the stale read surfaced by Antithesis - rebuild the basescan visibility checker and heap fetch state on rescan so cached relation sizes stay in sync with the heap ## Testing - cargo test -p pg_search basescan_reset_refreshes_visibility_checker_after_heap_shrink -- --nocapture - cargo check --workspace --------- Signed-off-by: Philippe Noël <[email protected]> (cherry picked from commit 0234165)
philippemnoel
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4446 to
0.22.x.