feat: Allow Top N + aggregates over literal normalized fields#4007
Merged
rebasedming merged 2 commits intomainfrom Jan 28, 2026
Merged
feat: Allow Top N + aggregates over literal normalized fields#4007rebasedming merged 2 commits intomainfrom
rebasedming merged 2 commits intomainfrom
Conversation
rebasedming
requested review from
mdashti,
philippemnoel and
stuhood
as code owners
rebasedming
added
cherry-pick/0.23.x
philippemnoel
approved these changes
Jan 27, 2026
stuhood
approved these changes
Jan 27, 2026
Collaborator
There was a problem hiding this comment.
As discussed: this is a step towards:
- making all tokenizers optionally fast,
- potentially renaming
literal_normalized, because it is not really "literal" so much as it is "single token with configurable token filters"
...But we won't cherry-pick those changes, so #shipit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
It turns out fast fields store the untokenized representations of text (we had a misconception that the tokenized representations were being stored). As a result, any fast field can participate in Top N/aggregate pushdown since the ordering/grouping semantics of fast fields are unchanged vs. the raw Postgres values.
Why
How
Tests