fix: crash in parallel hash joins with generic plans#3881
Merged
Conversation
This reverts commit 928f141.
mdashti
added
cherry-pick/0.23.x
mdashti
changed the title
mdashti
requested review from
philippemnoel,
rebasedming and
stuhood
as code owners
stuhood
approved these changes
Jan 10, 2026
Signed-off-by: Moe <[email protected]>
mdashti
commented
Jan 11, 2026
mdashti
removed
the
cherry-pick/0.22.x
paradedb-bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
# Ticket(s) Closed - Closes #N/A ## What Fix a crash that occurs when executing prepared statements with parallel hash joins on BM25 indexes after PostgreSQL switches to a generic plan (6th execution). ## Why Queries using parallel hash joins with BM25 indexes crash when PostgreSQL transitions from custom plans to generic plans. This affects any prepared statement executed 6+ times with parallel workers enabled. ## How The crash occurs due to memory/state issues when parallel workers are spawned for queries involving our index access method. The issue manifests after multiple query executions, suggesting state leakage or improper memory handling between executions. ## Tests Added regression test `parallel_hash_join_race.sql` that reproduces the crash. --------- Signed-off-by: Moe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Fix a crash that occurs when executing prepared statements with parallel hash joins on BM25 indexes after PostgreSQL switches to a generic plan (6th execution).
Why
Queries using parallel hash joins with BM25 indexes crash when PostgreSQL transitions from custom plans to generic plans. This affects any prepared statement executed 6+ times with parallel workers enabled.
How
The crash occurs due to memory/state issues when parallel workers are spawned for queries involving our index access method. The issue manifests after multiple query executions, suggesting state leakage or improper memory handling between executions.
Tests
Added regression test
parallel_hash_join_race.sqlthat reproduces the crash.