You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
dynamic_filters of SegmentedTopKExec->HashJoinExec plans includes orphaned dummy filter #5635
#5553 updated how dynamic filters were handled on additional filter pushdown passes. As a result, plans that have a SegmentedTopKExec inserted between a SortExec and a HashJoinExec end up with an orphaned dummy filter.
The SegmentedTopKExec is inserted after the first pushdown run. At that point, the SortExec has pushed down a filter. After insertion, SegmentedTopKExec removes the need for that filter, but does not remove the filter. This inflates the reported count of dynamic filters used in PgSearchScan.
To Reproduce
See the regression test outputs for any join query involving SegmentedTopKExec
OS:
macOs
ParadeDB Version (e.g. output of SELECT * FROM paradedb.version_info();):
v0.24.3
Are you using ParadeDB Docker, Helm, or the extension(s) standalone?
ParadeDB pg_search Extension
Full Name:
RJ Barman
Affiliation:
ParadeDB
Did you include all relevant data sets for reproducing the issue?
Yes
Did you include the code required to reproduce the issue?
Yes, I have
Did you include all relevant configurations (e.g., CPU architecture, PostgreSQL version, Linux distribution) to reproduce the issue?
Once #5766 is merged, fixing this should also remove the need do a second pushdown pass in serialize_physical_plan.rs, as SegmentedTopKExec should be taking ownership of the SortExecs existing filter, removing the need to push down a new one.
Activity
chore: Upgrade to datafusion 55 (#5634)
barbarj commentedon Jul 30, 2026
Once #5766 is merged, fixing this should also remove the need do a second pushdown pass in
serialize_physical_plan.rs, asSegmentedTopKExecshould be taking ownership of theSortExecs existing filter, removing the need to push down a new one.barbarj commentedon Jul 30, 2026
@devdattatalele Feel free to
/takethis since you've been working on the PR for it.devdattatalele commentedon Jul 30, 2026
/take
Will rework #5721 into the ownership-transfer shape once #5766 lands.
fix: SegmentedTopKExec takes ownership of SortExec dynamic filter on …
test: regression test for issue paradedb#5635 orphaned dynamic filter
fix: SegmentedTopKExec takes ownership of SortExec dynamic filter on …
test: regression test for issue paradedb#5635
fix: SegmentedTopKExec takes ownership of SortExec dynamic filter on …
test: regression test for issue paradedb#5635
fix: strip orphaned SortExec dynamic filter when SegmentedTopKExec is…
fix: strip orphaned SortExec dynamic filter when SegmentedTopKExec is…