add --transitive-only option to export-classpath!#8605
Merged
wisechengyi merged 2 commits intopantsbuild:masterfrom Nov 10, 2019
Merged
add --transitive-only option to export-classpath!#8605wisechengyi merged 2 commits intopantsbuild:masterfrom
wisechengyi merged 2 commits intopantsbuild:masterfrom
Conversation
cosmicexplorer
requested review from
Eric-Arellano,
blorente,
stuhood and
wisechengyi
wisechengyi
reviewed
Nov 9, 2019
Contributor
wisechengyi
left a comment
wisechengyi
left a comment
There was a problem hiding this comment.
Thanks, Danny! just some nits.
src/python/pants/backend/jvm/tasks/jvm_compile/jvm_classpath_publisher.py
Outdated
Show resolved
Hide resolved
wisechengyi
approved these changes
Nov 9, 2019
cosmicexplorer
force-pushed
the
transitive-only-export-classpath
branch
from
a4ae65f to
3d3f95c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We would like to be able to provide binary versions of all dependencies of specified root targets to an IDE with
export-classpath, without providing binary versions of the target roots themselves (because the IDE will be indexing those itself, as source files).--queryfrom #7350 might help here, but until that's developed a little further, it would be great to have this functionality now.@olafurpg requested this change to help integrate pants with metals.
Solution
--transitive-onlyoption to theexport-classpathtask which avoids publishing jars for target roots, and instead only pulls in their dependencies!