Skip to content

Switch the pants repo to use uv lockfiles#23293

Merged
benjyw merged 10 commits into
pantsbuild:mainfrom
benjyw:test_pants_with_uv_lockfiles
May 19, 2026
Merged

Switch the pants repo to use uv lockfiles#23293
benjyw merged 10 commits into
pantsbuild:mainfrom
benjyw:test_pants_with_uv_lockfiles

Conversation

@benjyw

@benjyw benjyw commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Includes in-repo lockfiles and the ones we
embed as default lockfiles for Python tools.

Does not include a handful of lockfiles used
in tests. Those will be done in a followup.

@benjyw benjyw added the release-notes:not-required [CI] PR doesn't require mention in release notes label Apr 27, 2026
@benjyw
benjyw force-pushed the test_pants_with_uv_lockfiles branch 7 times, most recently from 7e40d73 to 3f40bdc Compare April 30, 2026 18:13
@benjyw
benjyw force-pushed the test_pants_with_uv_lockfiles branch 2 times, most recently from 52fa9d0 to d9e88e2 Compare May 7, 2026 22:04
@benjyw
benjyw force-pushed the test_pants_with_uv_lockfiles branch from d9e88e2 to 46cd6bb Compare May 7, 2026 22:21
@benjyw
benjyw marked this pull request as ready for review May 7, 2026 22:22
@benjyw benjyw changed the title Test pants with uv lockfiles Switch the pants repo to use uv lockfiles May 7, 2026
@benjyw

benjyw commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

Reviewers: The first commit includes the very minor manual changes and can use human scrutiny. The second is the very large number of changes created by generate-lockfiles.

@benjyw
benjyw requested review from cburroughs and sureshjoshi May 7, 2026 22:24
@sureshjoshi

Copy link
Copy Markdown
Member

We didn't lose anything noteworthy in those 10k lines?

@sureshjoshi

Copy link
Copy Markdown
Member

Also, did this come with any version updates on that generation?

@benjyw

benjyw commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

We didn't lose anything noteworthy in those 10k lines?

No, the info in the files is equivalent (pex lockfiles have a few more lines of metadata, but that's not all that significant). It's more that the uv format crams more info per line.

@benjyw

benjyw commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

Also, did this come with any version updates on that generation?

It did. I should probably mention those in the release notes.

@benjyw

benjyw commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

Added to the release notes.

@cburroughs

Copy link
Copy Markdown
Contributor

I think dogfooding with python-default makes a lot of sense as a next step.

I'm less sure about switching all of the bundled tools lockfiles. That seems like a broader change. Do we know for example if this is faster or slower when used?

@sureshjoshi

Copy link
Copy Markdown
Member

I think dogfooding with python-default makes a lot of sense as a next step.

I'm less sure about switching all of the bundled tools lockfiles. That seems like a broader change. Do we know for example if this is faster or slower when used?

I don't think we're cherry picking this into 2.32, so I specifically think we SHOULD try this now and revert it later if things go off the rails.

@benjyw

benjyw commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

Definitely not for cherry-picking.

@benjyw
benjyw force-pushed the test_pants_with_uv_lockfiles branch from 678a7f2 to e63ed0e Compare May 16, 2026 20:26
@benjyw
benjyw merged commit 2693df8 into pantsbuild:main May 19, 2026
25 checks passed
@benjyw
benjyw deleted the test_pants_with_uv_lockfiles branch May 19, 2026 06:13
@jsirois

jsirois commented May 19, 2026

Copy link
Copy Markdown
Contributor

Noting that this failed - spectacularly - on main due to issues users have already pointed out, but were seemingly ignored. The current treatment does not work with remote caching: #23344 (comment)

@benjyw

benjyw commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Yikes, that is bad (of me). Revert here: #23360

I did not remember that we use remote caching (only on intra-fork merges).
But in any case, this would harm users too so I should never have merged it.

benjyw added a commit that referenced this pull request May 19, 2026
CI fails on main due to remote caching failures.

This was not picked up in PR CI because we don't
use remote caching across forks. Not anticipating
this was my error.

`uv` support needs more work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants